-
Notifications
You must be signed in to change notification settings - Fork 14
Fix changelog and release 1.21.1 #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @cityofships, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request finalizes the release of version "1.21.1" by updating the project's version number and documenting the included bug fixes. The changes ensure that the official changelog and version manifest accurately reflect the latest release, which addresses specific issues with precheck group existence checks. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares for the 1.21.1 release by updating the version in galaxy.yml and adding release notes to CHANGELOG.rst and changelogs/changelog.yaml. The changes are straightforward and correct for a release. However, I've noted a versioning inconsistency where the changelogs appear to be missing several releases that seem to have occurred based on the version bump in galaxy.yml. It would be beneficial to address this for better project history tracking.
| namespace: "stackhpc" | ||
| name: "cephadm" | ||
| version: "1.21.0" | ||
| version: "1.21.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version is being bumped from 1.21.0 to 1.21.1. However, the changelog files (CHANGELOG.rst and changelogs/changelog.yaml) are missing entries for versions between 1.19.1 and 1.21.1 (e.g., 1.20.x, 1.21.0). This creates a discrepancy between the collection version and the documented release history. To maintain consistency and a clear project history, it would be beneficial to add the missing release notes for versions 1.20.0 through 1.21.0 or clarify why they are absent.
No description provided.