GitHub V1

[jackhodgkiss]

This PR exists to address the comments left by @markgoddard here.

• updated README
• removal of template hooks in faviour of variable based hooks
• collection as opposed to role
• use of github prefix on role variables
• renaming of some variables
• support for customising docker registry, username and password
• support for adding or removing workflows without having to redefine all workflows
• removed magic [4:-4] in favour of format_file_name macro

A copy of each workflow can be found at this gist. Each workflow has been generated with the default settings with the exception of github_checkout_hook to demonstrate the inclusion of an additional step.

Missing support for tests and support for printing properties.

[Alex-Welsh]

EOF newlines on:
roles/github/templates/run-tempest.yml.j2
roles/github/templates/run-config-diff.yml.j2
roles/github/templates/generic.yml.j2
roles/github/templates/build-kayobe-docker-image.yml.j2

[jackhodgkiss]

EOF newlines on: roles/github/templates/run-tempest.yml.j2 roles/github/templates/run-config-diff.yml.j2 roles/github/templates/generic.yml.j2 roles/github/templates/build-kayobe-docker-image.yml.j2

That is done to ensure the generated files have the correct EOF newlines. Jinja2 whitespace is awkward.

[markgoddard]

This PR exists to address the comments left by @markgoddard here.

• updated README
• removal of template hooks in faviour of variable based hooks
• collection as opposed to role
• use of github prefix on role variables
• renaming of some variables
• support for customising docker registry, username and password
• support for adding or removing workflows without having to redefine all workflows
• removed magic [4:-4] in favour of format_file_name macro

A copy of each workflow can be found at this gist. Each workflow has been generated with the default settings with the exception of github_checkout_hook to demonstrate the inclusion of an additional step.

Missing support for tests and support for printing properties.

I don't think this one has been addressed: https://github.com/jackhodgkiss/kayobe_automation_workflows/commit/8a0538b1316c68c6a4015bd17835a156791bdfe6#r114438404. I'm not really sure what the poetry stuff is for.

Would be nice to get this into stackhpc-release-train and use the new collection linting workflows.

[jackhodgkiss]

I don't think this one has been addressed: jackhodgkiss/kayobe_automation_workflows@8a0538b#r114438404. I'm not really sure what the poetry stuff is for.

The poetry config/lock was for managing some developer dependencies when writing this and other ansible content. It can be removed as nothing relies upon it.