Adding user_domain and project_domain options and suitable fallbacks/omission

[ianwatsonrh]

Adding user_domain and project_domain options and suitable fallbacks/omission.

This requires openstack.cloud 2.5.0 specifically commit 437438e33c

See https://opendev.org/openstack/ansible-collections-openstack/commit/437438e33c836d50c1f6e3ef22a88226fdac239d for further usage

[gemini-code-assist]

Summary of Changes

Hello @ianwatsonrh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the OpenStack project management by introducing explicit user_domain and project_domain parameters for user role assignments. This change allows for more precise control over user and project domains within OpenStack, improving flexibility and alignment with OpenStack's identity management. A necessary update to the openstack.cloud Ansible collection dependency ensures compatibility with these new features.

Highlights

• Dependency Update: The openstack.cloud collection dependency has been updated to version ">=2.5.0" to support new functionalities required by this change.
• Domain Options for User Roles: New user_domain and project_domain options have been introduced when assigning user roles to projects, allowing for more granular control over domain-specific assignments.
• Fallback Logic for Domain Parameters: Fallback mechanisms are implemented for user_domain (defaulting to project.user_domain or omit) and project_domain (defaulting to omit) to ensure graceful handling of undefined values and maintain compatibility.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the openstack.cloud dependency and adds user_domain and project_domain options to the os_projects role, enhancing its multi-domain support. The changes are a good step forward, but there is a critical issue where the user creation task does not respect the new per-user domain setting, which will cause failures. I've also included a suggestion to make the domain handling more robust against empty string values. Additionally, it would be beneficial to update the role's documentation (in README.md and defaults/main.yml) to reflect the new per-user domain option.

[jovial]

Looks good to me, thank you very much