Only enable grafana repos during install #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkjpryor
approved these changes
Jun 19, 2024
mkjpryor
left a comment
mkjpryor
left a comment
There was a problem hiding this comment.
LGTM as a quick fix for now. As previously discussed, the long-term fix is to containerise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grafana repos are flaky, so any dnf operations (not just those on grafana packages) can fail due to being unable to update metadata from these repos. This PR disables the grafana repo by default, only enabling it during grafana package install.
Removes support for apt given we don't use it to simplify logic changes/testing.