-
Notifications
You must be signed in to change notification settings - Fork 19
Fix login-only nodes in configless mode #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovial
reviewed
Jan 7, 2021
jovial
approved these changes
Jan 8, 2021
jovial
reviewed
Jan 8, 2021
jovial
reviewed
Jan 8, 2021
jovial
reviewed
Jan 8, 2021
jovial
approved these changes
Jan 8, 2021
Contributor
jovial
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty clean - nice work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In configless mode compute nodes have an environment var set to tell slurmd what the the slurmctld host is. Login-only nodes don't have this so slurm commands can't work.
There are three possible approaches (docs):
This PR implements 3). I don't particularly like the implementation but here's why it is the best I could come up with:
vars/ohpc-2) already includes packages for slurmd.ohpc_slurm_services = slurmdso that slurmd gets configured. This could be done simply by settingopenhpc_enable.batch=True.NodeNameentry for each login-only node. Entries don't need any other information and don't need to be included in any partition.openhpc_slurm_partitionsdesign its very hard to extract the set ofbatchnodes which aren't listed in any partition. (This set is the login-only nodes). Therefore a newopenhpc_enable.loginflag is added to explicitly identify such nodes, rather than setting.batch = True.openhpc_enableis a role var it doesn't end up in hostvars so there's no way to find the.loginnodes from within the templating. Hence,runtime.ymlhas to set a factopenhpc_login_onlyto get this info into hostvars (I considered calling thisopenhpc_enable_loginbut thought the similarity toopenhpc_enable.loginwould actually be confusing not helpful).