Synchronise 2025.1 with upstream#16
Merged
Merged
Conversation
Ensure that volume target properties are properly redacted when the user lacks the 'baremetal:volume:view_target_properties' policy in patch() similar to get_one(). Additionally, Ironic Core Security determined that the RBAC reliant control over who can see properties was insufficient, especially in standalone use cases, and such the field handling is now consistent with other sensitive field usage. Assisted-By: Claude Opus 4.6 Related-Bug: 2154564 Related-Bug: 2155049 Change-Id: I8366088731aa34da0e99941924c222ffed455c8b Signed-off-by: Saad Zia <saad.zia@est.tech> Signed-off-by: Julia Kreger <juliaashleykreger@gmail.com>
The kernel parameter validator introduced in commit c6c91d6 has three bugs in the KernelParameterTransformer class: 1. The quoted_value() method tries to access items[0].value but items[0] is already a plain string (returned by value_with_spaces transformer), not a lark Token. This causes all quoted parameter values (e.g. sshkey="ssh-rsa ... user@host") to fail with "'str' object has no attribute 'value'". 2. KernelParameter.__str__() uses self.value.value directly, bypassing ParameterValue.__str__() which wraps space-containing values in quotes. This breaks roundtrip rendering of quoted values. 3. parse() does not strip surrounding whitespace from the input, causing failures when config values have trailing spaces or newlines from template expansion or oslo.config. Assisted-By: Claude Opus 4.6 Change-Id: I9a398d557c3f87c070ffa10e317f0df613b98b6b Signed-off-by: Riccardo Pittau <elfosardo@gmail.com> (cherry picked from commit a58fe7d) (cherry picked from commit 87807ea) (cherry picked from commit 1908af6)
… into stable/2025.1
github-actions
Bot
added
automated
priteau
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2025.1 from upstream stable/2025.1.