Synchronise master with upstream#565
Merged
Merged
Conversation
End goal is to reduce the reliance on facts for when we have the such details encoded in config. This is a step in that direction. Change-Id: I5a2d5f973a85efc4f561ececf2c83b2981a419b8 Signed-off-by: Will Szumski <will@stackhpc.com>
The issue was that we were caching these with ansible_user and ansible_python_interpreter overriden. This caused failures later on. We still want to run this before the kayobe target venv has been added so that we can use the CA for installing software packages. Change-Id: Id6373aa5eef515f5d6bd3176f71fe8b35333a009 Signed-off-by: Will Szumski <will@stackhpc.com>
Replace ansible_managed usage in tracked Kayobe templates with kayobe_managed to avoid the DEFAULT_MANAGED_STR deprecation scheduled for removal in ansible-core 2.23. Use "Ansible managed" as the fallback value so rendered output matches the historical default text. https://docs.ansible.com/projects/ansible-core/devel/reference_appendices/config.html#default-managed-str Change-Id: I1a7a4a57115bdce8c7406d1a3b5f90d764944c7b Signed-off-by: Will Szumski <will@stackhpc.com>
The kolla_ansible_host_vars action plugin previously returned facts via ansible_facts with _ansible_facts_cacheable set to False. This prevented the plugin from directly writing to the fact cache, but facts already in the in-memory ansible_facts dict can still be persisted by later cache writes (e.g. from gather_facts with gathering = smart), resulting in a partial and potentially stale fact set being loaded on subsequent runs. Fix this by returning facts under a custom kolla_ansible_host_vars result key instead. The playbook then applies them as host variables using a single set_fact task, which writes to the host vars scope and is never persisted to the fact cache. Closes-Bug: #2144548 Change-Id: I5b8827f9e95992d4a63d5fc96fbd131531dfd439 Signed-off-by: Will Szumski <will@stackhpc.com>
Switch all dependencies to use the OpenStack 2026.1 release. This commit should be reverted on the master branch once the Kayobe stable/2026.1 branch has been cut and RC1 released. Change-Id: I8fa9a48dd887497312812a064523a1ccc5b8bdaf Signed-off-by: Will Szumski <will@stackhpc.com>
Drop a small set of nmstate unit tests that duplicate behavior already covered by more targeted cases. Signed-off-by: Grzegorz Koper <grzegorzk@stackhpc.com> Change-Id: I0dd549a0066eb4076941af3ac417181a16dc096f
Related-Bug: #2153110 Change-Id: I0ef2c3dc5bfb87fc2f18f6fb92cd5f0f3e546577 Co-Authored-By: Michal Nasiadka <mnasiadka@gmail.com> Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Bump community.docker to 5.2.0, MichaelRigart.interfaces to v1.17.0 and stackhpc.libvirt-vm to v1.16.4. Update jriguera.configdrive to the latest commit SHA. Change-Id: Ib42e07912d1fbffe4a82584f26126ff953585879 Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Closes-Bug: #2148457 Change-Id: I3618a2b1050b69a031a5d09e30269fcfbddeff8d Signed-off-by: Will Szumski <will@stackhpc.com>
The following warning was visible in CI logs:
cp: warning: behavior of -n is non-portable and may change in
future; use --update=none instead
Change-Id: I915561e73108fa0c4c1e977a3b88271f69ff6002
Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Change-Id: I677ff46661fe98f6cb3bc35f6e13a3b12bf39066 Signed-off-by: Will Szumski <will@stackhpc.com>
Change-Id: Ib6bba94bf5938bdd84a71f42fde395659fe5a6f4 Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Docker Engine 29.5.2 is out and fixes the regression introduced in 29.5.1 [1]. This reverts commit 43294ef. [1] https://docs.docker.com/engine/release-notes/29/#2952 Closes-Bug: #2153110 Change-Id: Ib1ce90cd9174a190248e11512308828a2719ba49 Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Change-Id: I7b178183132e5dbd77329319d21fbf4ea4c43a9c Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Extends the seed's "custom containers" feature to support deploying containers on infrastructure VMs, overcloud and Ansible control hosts. Co-Authored-By: Leonie Chamberlin-Medd <leonie@stackhpc.com> Change-Id: I19ba61e90c78e088b740feed3dac1f6d1ad262ab Signed-off-by: Pierre Riteau <pierre@stackhpc.com> Signed-off-by: Leonie Chamberlin-Medd <leonie@stackhpc.com> Signed-off-by: Matt Crees <mattc@stackhpc.com>
It will now ping between "two" hosts. Since this is an AIO, the same host is added to the ansible inventory twice. This effectively makes the host ping itself. It does mean the task is not skipped. Depends-On: https://review.opendev.org/c/openstack/kayobe-config-dev/+/986140 Change-Id: I33189b5be3e4622fd37ee854410258c1f8d41781 Signed-off-by: Will Szumski <will@stackhpc.com>
When ``ansible-galaxy collection install`` is called with two requirements files, only the latter one is registered and dependencies on the first requirements file are ignored. Fixing by performing two separate ansible-galaxy installation. One for core collections (Defined at file path ``kolla_ansible_core_requirements_yml``) and another for additional collections (Defined at file path ``kolla_ansible_requirements_yml``). Closes-Bug: #2153994 Change-Id: Ie179ac46c28c08f3ed41922485ef2e532a2d6e46 Signed-off-by: Seunghun Lee <seunghun@stackhpc.com>
github-actions
Bot
added
automated
priteau
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of master from upstream master.