Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Rust compiler from version 1.78.0 to 1.88.0 and updates numerous dependencies to their latest compatible versions. The changes include modernizing deprecated API calls, updating string formatting to use inline syntax, and adjusting test expectations to match updated error message formats from dependencies.
Changes:
- Rust compiler upgraded from 1.78.0 to 1.88.0
- Major dependencies updated including AWS SDK, tokio, bytes, and numerous others
- Deprecated Rust standard library methods replaced with modern equivalents (e.g.,
max_value()→MAX) - String formatting modernized to use inline syntax (e.g.,
format!("{}", x)→format!("{x}")) - Code made more idiomatic (e.g.,
iter().any(|x| *x == 0)→contains(&0)) - Unused imports removed and clippy lint configured
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Rust version bumped to 1.88.0, dependencies updated, new clippy lint allowed |
| Cargo.lock | Extensive dependency version updates reflecting changes in Cargo.toml |
| src/validated_json.rs | Format strings updated to inline syntax |
| src/types/missing.rs | Deprecated max_value()/min_value() replaced with MAX/MIN, unused import removed, test expectations updated |
| src/types/dvalue.rs | Deprecated max_value()/min_value() replaced with MAX/MIN, test expectations updated |
| src/s3_client.rs | Format strings updated to inline syntax |
| src/models.rs | Replaced iter().any() with contains(), test error message expectations updated |
| src/error.rs | Format strings updated to inline syntax |
| src/compression.rs | Format strings updated to inline syntax |
| src/chunk_store.rs | Format strings updated to inline syntax |
| src/chunk_cache.rs | Format strings updated to inline syntax |
| src/array.rs | Deprecated methods replaced, unused import removed |
| src/app.rs | Format strings updated to inline syntax |
| benches/*.rs | Format strings updated to inline syntax across all benchmark files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9898038 to
55684de
Compare
55684de to
d8a129c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have lots of dependencies to update, some of those necessitate an update of the compiler and that in turn necessitates more dependency updates for those that no longer compile.
Bit of an overhaul really.