Skip to content

Upgrade compiler and dependencies#113

Merged
maxstack merged 2 commits intomainfrom
upgrade-compiler-and-dependencies
Feb 25, 2026
Merged

Upgrade compiler and dependencies#113
maxstack merged 2 commits intomainfrom
upgrade-compiler-and-dependencies

Conversation

@maxstack
Copy link
Copy Markdown
Collaborator

We have lots of dependencies to update, some of those necessitate an update of the compiler and that in turn necessitates more dependency updates for those that no longer compile.
Bit of an overhaul really.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Rust compiler from version 1.78.0 to 1.88.0 and updates numerous dependencies to their latest compatible versions. The changes include modernizing deprecated API calls, updating string formatting to use inline syntax, and adjusting test expectations to match updated error message formats from dependencies.

Changes:

  • Rust compiler upgraded from 1.78.0 to 1.88.0
  • Major dependencies updated including AWS SDK, tokio, bytes, and numerous others
  • Deprecated Rust standard library methods replaced with modern equivalents (e.g., max_value()MAX)
  • String formatting modernized to use inline syntax (e.g., format!("{}", x)format!("{x}"))
  • Code made more idiomatic (e.g., iter().any(|x| *x == 0)contains(&0))
  • Unused imports removed and clippy lint configured

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Rust version bumped to 1.88.0, dependencies updated, new clippy lint allowed
Cargo.lock Extensive dependency version updates reflecting changes in Cargo.toml
src/validated_json.rs Format strings updated to inline syntax
src/types/missing.rs Deprecated max_value()/min_value() replaced with MAX/MIN, unused import removed, test expectations updated
src/types/dvalue.rs Deprecated max_value()/min_value() replaced with MAX/MIN, test expectations updated
src/s3_client.rs Format strings updated to inline syntax
src/models.rs Replaced iter().any() with contains(), test error message expectations updated
src/error.rs Format strings updated to inline syntax
src/compression.rs Format strings updated to inline syntax
src/chunk_store.rs Format strings updated to inline syntax
src/chunk_cache.rs Format strings updated to inline syntax
src/array.rs Deprecated methods replaced, unused import removed
src/app.rs Format strings updated to inline syntax
benches/*.rs Format strings updated to inline syntax across all benchmark files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@maxstack maxstack force-pushed the upgrade-compiler-and-dependencies branch 4 times, most recently from 9898038 to 55684de Compare February 25, 2026 16:53
@maxstack maxstack force-pushed the upgrade-compiler-and-dependencies branch from 55684de to d8a129c Compare February 25, 2026 17:00
@maxstack maxstack merged commit 413db33 into main Feb 25, 2026
8 checks passed
@maxstack maxstack deleted the upgrade-compiler-and-dependencies branch February 25, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants