Add support for building iscsid #1963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 84f125b)
bbezak
approved these changes
Nov 3, 2025
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for building the iscsid Kolla container image by enabling it in the CI environment, adding its image tags, and including it in the list of images to be managed by Pulp. The changes are generally correct and follow the repository's conventions. However, I've identified two issues related to the project's tooling (tools/kolla-images.py) that need to be addressed. One is a misnamed key in kolla-image-tags.yml which will lead to incorrect tag resolution for the tgtd container. The other is a missing update in the tooling to reflect that the iscsid image is used by multiple containers. Both issues are detailed in the review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 84f125b)