Skip to content

Conversation

@jackhodgkiss
Copy link
Contributor

@jackhodgkiss jackhodgkiss self-assigned this Nov 24, 2025
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner November 24, 2025 22:46
@jackhodgkiss jackhodgkiss added documentation Improvements or additions to documentation s Small (Less than 50 change) labels Nov 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an important warning to the Ubuntu Noble upgrade documentation regarding Ceph hosts. The changes correctly highlight the prerequisite of running Ceph Reef v18.2.5 or later before upgrading. My review focuses on improving the clarity and conciseness of the new warning messages to ensure users fully understand the requirement and its implications. I've provided a couple of suggestions to make the text more direct and easier to follow.

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I was being picky, I'd say we should include a link to the Ceph upgrade docs, but I don't think it should hold this up

jackhodgkiss and others added 3 commits November 26, 2025 10:02
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
@priteau priteau merged commit e56780e into stackhpc/2025.1 Nov 27, 2025
20 of 21 checks passed
@priteau priteau deleted the ceph-ubuntu-noble-warning branch November 27, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation s Small (Less than 50 change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants