-
Notifications
You must be signed in to change notification settings - Fork 23
docs: add warning for Noble upgrade on Ceph hosts
#1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an important warning to the Ubuntu Noble upgrade documentation regarding Ceph hosts. The changes correctly highlight the prerequisite of running Ceph Reef v18.2.5 or later before upgrading. My review focuses on improving the clarity and conciseness of the new warning messages to ensure users fully understand the requirement and its implications. I've provided a couple of suggestions to make the text more direct and easier to follow.
Alex-Welsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I was being picky, I'd say we should include a link to the Ceph upgrade docs, but I don't think it should hold this up
See bug https://tracker.ceph.com/issues/66389 Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
3e922da to
992a7b6
Compare
See bug https://tracker.ceph.com/issues/66389