Add Ironic repo#517
Merged
Merged
Conversation
dougszumski
force-pushed
the
conf/import_ironic
branch
from
6b603d6 to
e8623a9
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the ironic repository to the Ansible source repositories and Terraform configuration. The reviewer suggests reordering the ironic entry in the Ansible configuration to maintain alphabetical consistency with the Terraform file for better maintainability.
dougszumski
force-pushed
the
conf/import_ironic
branch
from
e8623a9 to
5bdff5f
Compare
Contributor
Terraform Format and Style 🖌
|
Member
|
Needs #516 first, otherwise I think it's going to break things |
Member
|
But other than that, lgtm |
Member
|
#516 merged, just want to wait until CI finishes now https://github.com/stackhpc/stackhpc-release-train/actions/runs/26039990575/job/76548597370 |
mnasiadka
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for back-porting to epoxy the ramdisk deploy feature (diskless boot)