Skip to content

Add stackhpc-zuul merge rights in Ansible,Kayobe and OpenStack repos#530

Merged
mnasiadka merged 1 commit into
mainfrom
zuul_merge_permissions
Jun 2, 2026
Merged

Add stackhpc-zuul merge rights in Ansible,Kayobe and OpenStack repos#530
mnasiadka merged 1 commit into
mainfrom
zuul_merge_permissions

Conversation

@mnasiadka
Copy link
Copy Markdown
Member

No description provided.

@mnasiadka mnasiadka requested a review from a team as a code owner June 2, 2026 10:53
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures various GitHub branch protection rules to allow the Zuul GitHub App to push to protected branches. It introduces a new zuul_app_id variable and uses the github_app_installation data source to retrieve the installation ID. However, the reviewer identified a critical issue: the push_allowances attribute requires the Node ID of the App rather than its installation ID. To resolve this, the reviewer suggested using the github_app data source with the app's slug to retrieve the correct node_id, which would also simplify the configuration by removing the need for the zuul_app_id variable.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread terraform/github/repositories.tf Outdated
@mnasiadka mnasiadka force-pushed the zuul_merge_permissions branch from 0a58f79 to aeba578 Compare June 2, 2026 11:10
@stackhpc-ci
Copy link
Copy Markdown
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Terraform Plan 📖success

Show Plan

undefined

Pusher: @mnasiadka, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

@mnasiadka mnasiadka merged commit 478eb8c into main Jun 2, 2026
5 checks passed
@mnasiadka mnasiadka deleted the zuul_merge_permissions branch June 2, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants