Able to add custom configuration for loggers#15
Merged
homiedopie merged 13 commits intostackify:masterfrom Nov 5, 2020
Merged
Conversation
added 12 commits
October 25, 2020 03:29
| } else { | ||
| $this->Headers = $this->getHeaders(); | ||
| $this->Cookies = isset($_COOKIE) ? self::getRequestMap($_COOKIE, ['*']) : null; | ||
| $this->QueryString = isset($_GET) ? self::getRequestMap($_GET) : null; |
There was a problem hiding this comment.
Since the whitelist is null here the default would be capture none of the query string parameters and none of the POST data. Not sure this code will ever get called, but if it does is that what we want to do?
homiedopie
commented
Nov 5, 2020
| $result = array(); | ||
| foreach ($headers as $key => $value) { | ||
| $maskValue = false; | ||
| $lowercaseKey = strtolower($key); |
Collaborator
Author
There was a problem hiding this comment.
Use WebRequestMap
kbond-stackify
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Able to add custom configuration for loggers