Patch/INV-1229 - Ruby logging issues #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slashd0t
commented
Feb 28, 2020
slashd0t
commented
- Fix the bug when using the config.log_level options and the authorization failure issue.
* Ruby API - Add new transport AGENT_HTTP Changes: - added new transport http_agent - refactor transport and reuse codes - added option to get value from environment variables - fix formatting - remove unused requires - fix typo
* RT-2599 Fix the authorization error issue in Passenger * Fix error that return undefined log_message_task for NilClass * Update unix socket sender Class * Exclude the Gemfile.lock * Reset Gemfile.lock to prev version
…so the <authorization failure>
darinhoward
reviewed
Feb 28, 2020
| INTERNAL_LOG_PREFIX = '[Stackify]'.freeze | ||
| STATUSES = { working: 'working', terminating: 'terminating', terminated: 'terminated'} | ||
| MODES = { logging: :logging, metrics: :metrics, both: :both } | ||
| TRANSPORT = [DEFAULT = 'default', UNIX_SOCKET = 'agent_socket', AGENT_HTTP = 'agent_http'] |
Contributor
There was a problem hiding this comment.
why the rename from default to log ?
Contributor
Author
There was a problem hiding this comment.
Just changed back from log to default options.
darinhoward
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.