Fix golangci lint url#1067
Conversation
|
LGTM label has been added. DetailsGit tree hash: e4cd6087e974f58a51d37870fc682bf724b9815d |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xoxys The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dergeberl: new pull request created: #1068 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dergeberl: new pull request created: #1069 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dergeberl: new pull request created: #1070 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dergeberl: new pull request created: #1071 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
In #1045 #1046 #1047 #1048 #1049 the golangci-lint version is bumped. But there is a new download URL, that is why this is failing currently.
This PR also directly address new lint findings with that new version of golang and goconst.
This is done separately (not within the update PR) to avoid merge issues during the cherry-pick.
/cherry-pick release-v1.33
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36