Sanitize K8s node names to meet load balancer target displayname requirements#1180
Conversation
|
/cherry-pick release-v1.33 |
|
@dergeberl: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ske-prow
Bot
added
the
size/M
nschad
left a comment
nschad
left a comment
There was a problem hiding this comment.
small nits
I would shorten the name of the function a bit and call a few things differently.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nschad The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
Bot
added
the
approved
|
LGTM label has been added. DetailsGit tree hash: 153eec06191e411c40cc9e53985d9cc9e8c3c06d |
|
@dergeberl: new pull request created: #1181 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dergeberl: new pull request created: #1182 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dergeberl: new pull request created: #1183 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dergeberl: new pull request created: #1184 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
How to categorize this PR?
/kind bug
/cc @stackitcloud/ske-infrastructure
What this PR does / why we need it:
The kubernetes node name can contain
.and can be longer than 63 characters which is not allowed asDisplayNamein the load balancer targets (^[0-9a-zA-Z](?:(?:[0-9a-zA-Z]|-){0,61}[0-9a-zA-Z])?$). This PR makes sure that the name is still as readable as possible but replaces invalid characters and shorten the name if needed.Which issue(s) this PR fixes:
Fixes #994