Skip to content

Workaround: Gardener Node Agent deletes containerd drop-in#122

Merged
ske-prow[bot] merged 1 commit intoske-v1.110from
ske-v1.110-desperate
Feb 3, 2025
Merged

Workaround: Gardener Node Agent deletes containerd drop-in#122
ske-prow[bot] merged 1 commit intoske-v1.110from
ske-v1.110-desperate

Conversation

@nschad
Copy link
Copy Markdown

@nschad nschad commented Feb 3, 2025

This reverts commit b88242d.

How to categorize this PR?

/area os
/kind bug

What this PR does / why we need it:

Reverting this as this will stop the gardener-node-agent from deleting our custom containerd system override.
This PR can potentially be dropped with v111 (if verified that it works) due to gardener#11015

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Feb 3, 2025

@nschad: The label(s) area/todo, kind/todo cannot be applied, because the repository doesn't have them.

Details

In response to this:

This reverts commit b88242d.

How to categorize this PR?

/area TODO
/kind TODO

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow ske-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2025
@nschad nschad added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Feb 3, 2025
@nschad nschad changed the title WIP: Revert ability to restart containerd Revert ability to restart containerd Feb 3, 2025
@ske-prow ske-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2025
@nschad
Copy link
Copy Markdown
Author

nschad commented Feb 3, 2025

/area os
/kind bug

@ske-prow ske-prow Bot added the kind/bug Bug label Feb 3, 2025
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Feb 3, 2025

@nschad: The label(s) area/os cannot be applied, because the repository doesn't have them.

Details

In response to this:

/area os
/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow ske-prow Bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Feb 3, 2025
@nschad nschad changed the title Revert ability to restart containerd Workaround: Gardener Node Agent deletes containerd drop-in Feb 3, 2025
@RAPSNX
Copy link
Copy Markdown

RAPSNX commented Feb 3, 2025

/lgtm
/approve

@ske-prow ske-prow Bot assigned RAPSNX Feb 3, 2025
@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Feb 3, 2025

LGTM label has been added.

DetailsGit tree hash: c9db03b29b9dc2f7daae798f63980661271e14fa

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@nschad
Copy link
Copy Markdown
Author

nschad commented Feb 3, 2025

/approve

@ske-prow ske-prow Bot merged commit ba0d75f into ske-v1.110 Feb 3, 2025
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nschad, rgroemmer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timebertt timebertt deleted the ske-v1.110-desperate branch September 17, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants