Skip to content

Rebase Patch v1.112.3#131

Merged
ske-prow[bot] merged 4 commits intoske-v1.112from
v1.112.3-rebase
Feb 25, 2025
Merged

Rebase Patch v1.112.3#131
ske-prow[bot] merged 4 commits intoske-v1.112from
v1.112.3-rebase

Conversation

@Duciwuci
Copy link
Copy Markdown

/kind enhancement

gardener-robot-ci-1 and others added 4 commits February 25, 2025 14:07
…ardener.cloud/` (gardener#11486)

* Rename `seed.gardener.cloud/` prefix to `.name.seed.gardener.cloud/`

due to potential naming conflicts when users also use
`seed.gardener.cloud/` as prefix for their labels (not ideal, they
should actually use a unique prefix (e.g., `seed.my.cool.domain.com/`),
but we cannot prevent it for historic reasons

* Migration code in GCM to re-compute seed labels

* Address PR review feedback

---------

Co-authored-by: rfranzke <rafael.franzke@sap.com>
@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2025
@lukasjarosch
Copy link
Copy Markdown

/lgtm

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Feb 25, 2025

LGTM label has been added.

DetailsGit tree hash: 1777d42b57b2ed29a9cf1ca2625722198ff5ee97

@Duciwuci
Copy link
Copy Markdown
Author

/approve

@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Duciwuci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
@ske-prow ske-prow Bot merged commit f1b2959 into ske-v1.112 Feb 25, 2025
@ske-prow ske-prow Bot deleted the v1.112.3-rebase branch February 25, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants