🍒 Cherry-Picks for v1.113.0#132
Merged
ske-prow[bot] merged 6 commits intoske-v1.113from Feb 26, 2025
Merged
Conversation
ske-prow
Bot
added
kind/enhancement
Duciwuci
commented
Feb 25, 2025
Duciwuci
added
the
tide/merge-method-rebase
ske-prow
Bot
added
size/M
Duciwuci
commented
Feb 25, 2025
Duciwuci
force-pushed
the
113-cherries
branch
from
4d55ec4 to
6a0645a
Compare
ske-prow
Bot
added
size/XS
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
Duciwuci
force-pushed
the
113-cherries
branch
from
11e4c98 to
8484eb4
Compare
ske-prow
Bot
added
size/S
The changes are similar to those made by pkg/provider-local/webhook/nodeagentosc/mutator.go
Duciwuci
force-pushed
the
113-cherries
branch
from
8484eb4 to
03e0b33
Compare
ske-prow
Bot
added
size/M
Since Prometheus Targets are all down due to gardener#9716 in Gardener v1.96, we need to set insecure_skip_verify to true on cadvisor & kubelet scrape config. Since this is a hotfix, it can be dropped whenever we have a long term solution.
Duciwuci
force-pushed
the
113-cherries
branch
from
03e0b33 to
020f622
Compare
|
LGTM label has been added. DetailsGit tree hash: 190f8f7e1fa888bc7561ee15d95796cfb55b4656 |
Duciwuci
force-pushed
the
113-cherries
branch
from
1b22957 to
9544dd1
Compare
ske-prow
Bot
added
size/L
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 71be43a49466035afdd6ada66aaf19bfa3c6728e |
this is not needed in our fork as the apiserver-proxy component already uses the reversed-vpn port (8132) for connecting to the shoot controlplane As we need to deploy g/g 1.113 with the feature gate already enabled, we can't wait for every shoot to reconcile and have the constraint set This can be dropped once every shoot has the constraint "APIServerProxyUsesHTTPProxy" set This will be the case once every shoot has been reconciled with g/g 1.113 or if we patch the constraint into the shoot status
Duciwuci
force-pushed
the
113-cherries
branch
from
9544dd1 to
2a34163
Compare
ske-prow
Bot
added
size/M
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 4c0cc013097727a006e34871cca95147c64a1ab3 |
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Duciwuci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind enhancement
Dropped Commits
RemoveAPIServerProxyLegacyPortnow handles this