Remove Extension Validation for Provider in ETCD-Backup#139
Merged
ske-prow[bot] merged 2 commits intoske-v1.114from Mar 24, 2025
Merged
Remove Extension Validation for Provider in ETCD-Backup#139ske-prow[bot] merged 2 commits intoske-v1.114from
ske-prow[bot] merged 2 commits intoske-v1.114from
Conversation
ske-prow
Bot
added
kind/enhancement
Duciwuci
added
the
tide/merge-method-rebase
Duciwuci
force-pushed
the
skip-s3-validation
branch
3 times, most recently
from
7c25aa9 to
2d7364d
Compare
Author
|
/hold let's test this first |
ske-prow
Bot
added
the
do-not-merge/hold
With Gardener v1.114+ the operator extensions are a required resource for the upgrade. In our use case, we need to deactivate this validation since this is a breaking change. We need to do a backup-s3 migration. Drop this commit, after the migration of the extension was performed.
Duciwuci
force-pushed
the
skip-s3-validation
branch
from
2d7364d to
b824eff
Compare
Author
|
/hold cancel |
ske-prow
Bot
removed
the
do-not-merge/hold
|
LGTM label has been added. DetailsGit tree hash: f16ab6b338583576de9a65e46c6f5b9c4aec76c5 |
Duciwuci
force-pushed
the
skip-s3-validation
branch
from
5f1b37d to
897273a
Compare
|
LGTM label has been added. DetailsGit tree hash: fb64c75a0ac45082ddce4c3ebf1cfe27dbad9329 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind enhancement
With Gardener v1.114+ the operator extensions are a required resource for the upgrade.
In our use case, we need to deactivate this validation since this is a breaking change.
We need to do a backup-s3 migration.
Drop this commit, after the migration of the extension was performed.