Skip to content

V1.116.0 cherry picks#143

Merged
ske-prow[bot] merged 6 commits intoske-v1.116from
v1.116.0-cherry-picks
Apr 15, 2025
Merged

V1.116.0 cherry picks#143
ske-prow[bot] merged 6 commits intoske-v1.116from
v1.116.0-cherry-picks

Conversation

@xoxys
Copy link
Copy Markdown
Member

@xoxys xoxys commented Apr 10, 2025

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

This PR applies our fork changes to the Gardener 1.116 release.

Umbrella Issue: https://github.com/stackitcloud/ske-base/issues/2700

@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Apr 10, 2025

@xoxys: The label(s) area/todo, kind/todo cannot be applied, because the repository doesn't have them.

Details

In response to this:

How to categorize this PR?

/area TODO
/kind TODO

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow ske-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Apr 10, 2025
@xoxys xoxys added the kind/enhancement Enhancement, improvement, extension label Apr 10, 2025
@ske-prow ske-prow Bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Apr 10, 2025
@xoxys xoxys force-pushed the v1.116.0-cherry-picks branch from a8e7df7 to 7c1e8d2 Compare April 10, 2025 15:23
@ske-prow ske-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2025
@xoxys xoxys force-pushed the v1.116.0-cherry-picks branch 2 times, most recently from 2d88303 to e38bf5f Compare April 14, 2025 13:23
@xoxys
Copy link
Copy Markdown
Member Author

xoxys commented Apr 14, 2025

/retest

2 similar comments
@xoxys
Copy link
Copy Markdown
Member Author

xoxys commented Apr 14, 2025

/retest

@xoxys
Copy link
Copy Markdown
Member Author

xoxys commented Apr 14, 2025

/retest

@xoxys
Copy link
Copy Markdown
Member Author

xoxys commented Apr 14, 2025

/help

@xoxys
Copy link
Copy Markdown
Member Author

xoxys commented Apr 14, 2025

/test all

Niclas Schad and others added 6 commits April 14, 2025 17:13
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
The changes are similar to those made by pkg/provider-local/webhook/nodeagentosc/mutator.go
Since Prometheus Targets are all down due to gardener#9716 in Gardener v1.96, we need to set insecure_skip_verify to true on cadvisor & kubelet scrape config.

Since this is a hotfix, it can be dropped whenever we have a long term
solution.
With Gardener v1.114+ the operator extensions are a required resource for the upgrade.
In our use case, we need to deactivate this validation since this is a breaking change.
We need to do a backup-s3 migration.

Drop this commit, after the migration of the extension was performed.
@xoxys xoxys force-pushed the v1.116.0-cherry-picks branch from e38bf5f to e0c85f8 Compare April 14, 2025 15:16
Copy link
Copy Markdown

@maboehm maboehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the umbrella and ensure the correct labels are set on the issue

@xoxys xoxys added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Apr 15, 2025
@xoxys xoxys requested a review from maboehm April 15, 2025 08:48
@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Apr 15, 2025

LGTM label has been added.

DetailsGit tree hash: 6a9f6ea560963a228635ecf044188d71d02d650c

@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maboehm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@ske-prow ske-prow Bot merged commit 57106b6 into ske-v1.116 Apr 15, 2025
4 checks passed
@ske-prow ske-prow Bot deleted the v1.116.0-cherry-picks branch April 15, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants