Skip to content

v1.118.0 cherry-picks#146

Merged
ske-prow[bot] merged 5 commits intoske-v1.118from
v1.118-cherry-picks
May 7, 2025
Merged

v1.118.0 cherry-picks#146
ske-prow[bot] merged 5 commits intoske-v1.118from
v1.118-cherry-picks

Conversation

@Wieneo
Copy link
Copy Markdown

@Wieneo Wieneo commented May 6, 2025

How to categorize this PR?

/kind enhancement
/label tide/merge-method-rebase

What this PR does / why we need it:
This PR applies our fork changes to the Gardener 1.118.0 release.

Umbrella Issue: https://github.com/stackitcloud/ske-base/issues/2848

maboehm and others added 2 commits May 6, 2025 15:46
The changes are similar to those made by pkg/provider-local/webhook/nodeagentosc/mutator.go
@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2025
@Wieneo
Copy link
Copy Markdown
Author

Wieneo commented May 6, 2025

/cc @stackitcloud/ske-gardener

@ske-prow ske-prow Bot requested a review from a team May 6, 2025 14:06
@xoxys
Copy link
Copy Markdown
Member

xoxys commented May 6, 2025

StaleExpirationTimeDays can be skipped this time as implemented by https://github.com/stackitcloud/ske-components/pull/402

timebertt and others added 3 commits May 7, 2025 06:56
Since Prometheus Targets are all down due to gardener#9716 in Gardener v1.96, we need to set insecure_skip_verify to true on cadvisor & kubelet scrape config.

Since this is a hotfix, it can be dropped whenever we have a long term
solution.
With Gardener v1.114+ the operator extensions are a required resource for the upgrade.
In our use case, we need to deactivate this validation since this is a breaking change.
We need to do a backup-s3 migration.

Drop this commit, after the migration of the extension was performed.
@Wieneo Wieneo force-pushed the v1.118-cherry-picks branch from fd527fe to efa0d14 Compare May 7, 2025 04:56
@Wieneo
Copy link
Copy Markdown
Author

Wieneo commented May 7, 2025

StaleExpirationTimeDays can be skipped this time as implemented by stackitcloud/ske-components#402

Dropped :)

@Wieneo
Copy link
Copy Markdown
Author

Wieneo commented May 7, 2025

/retest

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented May 7, 2025

LGTM label has been added.

DetailsGit tree hash: 6c83a9c4cc40bb52983724dd8b9f783d4e508e0f

@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented May 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2025
@ske-prow ske-prow Bot merged commit 8ad72d9 into ske-v1.118 May 7, 2025
4 checks passed
@ske-prow ske-prow Bot deleted the v1.118-cherry-picks branch May 7, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants