Skip to content

feat: Add InternalIPs to CreateMachineResponse#140

Merged
ske-prow[bot] merged 3 commits intomainfrom
feat/add-machine-internal-ip-status-field
Mar 23, 2026
Merged

feat: Add InternalIPs to CreateMachineResponse#140
ske-prow[bot] merged 3 commits intomainfrom
feat/add-machine-internal-ip-status-field

Conversation

@jamand
Copy link
Member

@jamand jamand commented Mar 16, 2026

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

Similar to gardener/machine-controller-manager-provider-openstack#322
Server InternalIPs are now returned on created Machines, so that they may be used for access. This is needed, as the provided hostname field already written into is the Machine Status.Addresses is not resolvable on STACKIT.

Which issue(s) this PR fixes:
x

Special notes for your reviewer:

The client Suite was previously not registered and there was a small bug in one test case.

/hold Running tests first

@ske-prow ske-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2026
@jamand jamand force-pushed the feat/add-machine-internal-ip-status-field branch from 0a4a0d5 to 2e0be67 Compare March 16, 2026 13:57
@jamand jamand force-pushed the feat/add-machine-internal-ip-status-field branch from 8439761 to 8f95f5f Compare March 20, 2026 11:35
Co-authored-by: Felix Breuer <f.breuer94@gmail.com>
@jamand jamand force-pushed the feat/add-machine-internal-ip-status-field branch from 8f95f5f to d39fd9f Compare March 20, 2026 11:43
@jamand
Copy link
Member Author

jamand commented Mar 20, 2026

@breuerfelix Thanks!

I also ran a test in an ondemand environment testing the self-hosted shoot scenario using gardenadm (only in this case the IP is written into the Status field. I could verify that the Addresses field now has an additional entry with the server internal IP (Type: InternalIP) next to the already previously created Hostname entry.

@jamand
Copy link
Member Author

jamand commented Mar 20, 2026

/unhold

@ske-prow ske-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2026
Copy link
Member

@breuerfelix breuerfelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also tested in ondemand that normal shoot creation still works

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026
@ske-prow
Copy link

ske-prow bot commented Mar 23, 2026

LGTM label has been added.

DetailsGit tree hash: 030959259b40456a1ced2557355b83e95fdd184f

@ske-prow
Copy link

ske-prow bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breuerfelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2026
@ske-prow ske-prow bot merged commit 44baa98 into main Mar 23, 2026
3 checks passed
@ske-prow ske-prow bot deleted the feat/add-machine-internal-ip-status-field branch March 23, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants