feat(routing-table): provide rt and routes functionality #1023

h3adex · 2025-10-10T14:23:50Z

Description

This PR adds functionality to list and describe routing tables, as well as perform full CRUD operations on routes within those tables. It does not include support for creating or attaching routing tables, as those operations are currently intended to be managed exclusively through Terraform.

This implementation is primarily aimed at enabling users to inspect and debug routes created via Terraform. Once the routing table feature reaches GA, support for creating routing tables and attaching them to networks will be added to the CLI.

Checklist

Issue was linked above
Code format was applied: make fmt
Examples were added / adjusted (see e.g. here)
Docs are up-to-date: make generate-docs (will be checked by CI)
Unit tests got implemented or updated
Unit tests are passing: make test (will be checked by CI)
No linter issues: make lint (will be checked by CI)

h3adex · 2025-10-10T14:25:56Z

internal/cmd/beta/routingtable/route/create/create.go

+	cmd.Flags().Var(flags.CIDRFlag(), destinationValueFlag, "Destination value")
+	cmd.Flags().String(nextHopValueFlag, "", "NextHop value")
+
+	cmd.Flags().Var(


I introduced an enum flag here. I'm not certain if this matches our intended cli design, but I felt it would be beneficial to validate values early.

h3adex · 2025-10-10T14:27:50Z

internal/cmd/beta/routingtable/route/create/create.go

+		Labels:           flags.FlagToStringToStringPointer(p, cmd, labelFlag),
+	}
+
+	// Next Hop validation logic


Also here I felt like it would be beneficial to validate values early. Can be tested with commands like:

bin/stackit beta routing-table route create --destination-type cidrv4 --destination-value 0.0.0.0/32 --nexthop-type internet --nexthop-value 1.1.1.1 --network-area-id xxx --organization-id yyy --routing-table-id zzz -o pretty

Expected: Error: --nexthop-value is not allowed when --nexthop-type is 'internet' or 'blackhole'

h3adex · 2025-10-10T14:28:44Z

internal/cmd/beta/routingtable/routingtable.go

+		Short: "Manage routing-tables and its according routes",
+		Long: `Manage routing tables and their associated routes.
+
+This functionality is currently in BETA. At this stage, only listing and describing


Added this to give the user a hint, that this is more used for debugging rather than being used for creating routing-tables and attaching them to networks.

h3adex · 2025-10-15T06:37:08Z

Update waiting for go-sdk iaas api update ^

rubenhoenle · 2025-10-20T10:19:38Z

internal/cmd/beta/routingtable/list/list_test.go

+	"github.com/stackitcloud/stackit-sdk-go/services/iaasalpha"
+)
+
+var testRegion = "eu01"


could be const

rubenhoenle · 2025-10-20T10:19:49Z

internal/cmd/beta/routingtable/list/list_test.go

+var testOrgId = uuid.NewString()
+var testNetworkAreaId = uuid.NewString()
+
+var testLabelSelectorFlag = "key1=value1,key2=value2"


could be const

rubenhoenle · 2025-10-20T10:22:48Z

internal/cmd/beta/routingtable/list/list_test.go

+
+	for _, tt := range tests {
+		t.Run(tt.description, func(t *testing.T) {
+			p := print.NewPrinter()


Please use the new testutils.TestParseInput func here to save us the boilerplate code.

https://github.com/stackitcloud/stackit-cli/blob/main/internal/cmd/image/list/list_test.go#L129

see also the PR #1033 for reference

rubenhoenle · 2025-10-20T10:23:13Z

internal/cmd/beta/routingtable/route/create/create_test.go

+var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
+var testClient = &iaasalpha.APIClient{}
+
+var testRegion = "eu01"


could be const

rubenhoenle · 2025-10-20T10:23:26Z

internal/cmd/beta/routingtable/route/create/create_test.go

+var testNetworkAreaId = uuid.NewString()
+var testRoutingTableId = uuid.NewString()
+
+var testDestinationTypeFlag = "cidrv4"


most variables here could be const

rubenhoenle · 2025-10-20T10:29:15Z

internal/cmd/beta/routingtable/route/describe/describe.go

+}
+
+func outputResult(p *print.Printer, outputFormat string, routingTable *iaasalpha.Route) error {
+	switch outputFormat {


Please use the new Printer.OutputResult func here to save us the boilerplate code for the JSON/YAML output.

stackit-cli/internal/pkg/print/print.go

Lines 247 to 268 in 4725975

func (p *Printer) OutputResult(outputFormat string, output any, prettyOutputFunc func() error) error {

switch outputFormat {

case JSONOutputFormat:

details, err := json.MarshalIndent(output, "", " ")

if err != nil {

return fmt.Errorf("marshal json: %w", err)

}

p.Outputln(string(details))

return nil

case YAMLOutputFormat:

details, err := yaml.MarshalWithOptions(output, yaml.IndentSequence(true), yaml.UseJSONMarshaler())

if err != nil {

return fmt.Errorf("marshal yaml: %w", err)

}

p.Outputln(string(details))

return nil

default:

return prettyOutputFunc()

}

}

stackit-cli/internal/cmd/image/list/list.go

Lines 139 to 178 in 4725975

return p.OutputResult(outputFormat, items, func() error {

table := tables.NewTable()

table.SetHeader("ID", "NAME", "OS", "ARCHITECTURE", "DISTRIBUTION", "VERSION", "LABELS")

for i := range items {

item := items[i]

var (

architecture string = "n/a"

os string = "n/a"

distro string = "n/a"

version string = "n/a"

)

if cfg := item.Config; cfg != nil {

if v := cfg.Architecture; v != nil {

architecture = *v

}

if v := cfg.OperatingSystem; v != nil {

os = *v

}

if v := cfg.OperatingSystemDistro; v != nil && v.IsSet() {

distro = *v.Get()

}

if v := cfg.OperatingSystemVersion; v != nil && v.IsSet() {

version = *v.Get()

}

}

table.AddRow(utils.PtrString(item.Id),

utils.PtrString(item.Name),

os,

architecture,

distro,

version,

utils.JoinStringKeysPtr(*item.Labels, ","))

}

err := table.Display(p)

if err != nil {

return fmt.Errorf("render table: %w", err)

}

return nil

})

see also the PR #1030 for reference

rubenhoenle · 2025-10-20T10:30:00Z

internal/cmd/beta/routingtable/route/list/list.go

+			}
+
+			if items := response.Items; items == nil || len(*items) == 0 {
+				params.Printer.Info("No routes  found for routing-table %q\n", *model.RoutingTableId)


Invalid output in case the --output-format flag is set to JSON/YAML output

rubenhoenle · 2025-10-20T10:30:58Z

internal/cmd/beta/routingtable/route/list/list.go

+			}
+
+			// Truncate output
+			items := *response.Items


Potential nil pointer dereference (I guess, didn't take a closer look). Please use response.GetItems() or this util func

stackit-cli/internal/pkg/utils/utils.go

Lines 256 to 261 in 4725975

func GetSliceFromPointer[T any](s *[]T) []T {

if s == nil || *s == nil {

return []T{}

}

return *s

}

rubenhoenle · 2025-10-20T10:31:42Z

internal/cmd/beta/routingtable/route/list/list.go

+}
+
+func outputResult(p *print.Printer, outputFormat string, items []iaasalpha.Route) error {
+	switch outputFormat {


Please use the new Printer.OutputResult func here to save us the boilerplate code for the JSON/YAML output.

stackit-cli/internal/pkg/print/print.go

Lines 247 to 268 in 4725975

func (p *Printer) OutputResult(outputFormat string, output any, prettyOutputFunc func() error) error {

switch outputFormat {

case JSONOutputFormat:

details, err := json.MarshalIndent(output, "", " ")

if err != nil {

return fmt.Errorf("marshal json: %w", err)

}

p.Outputln(string(details))

return nil

case YAMLOutputFormat:

details, err := yaml.MarshalWithOptions(output, yaml.IndentSequence(true), yaml.UseJSONMarshaler())

if err != nil {

return fmt.Errorf("marshal yaml: %w", err)

}

p.Outputln(string(details))

return nil

default:

return prettyOutputFunc()

}

}

stackit-cli/internal/cmd/image/list/list.go

Lines 139 to 178 in 4725975

return p.OutputResult(outputFormat, items, func() error {

table := tables.NewTable()

table.SetHeader("ID", "NAME", "OS", "ARCHITECTURE", "DISTRIBUTION", "VERSION", "LABELS")

for i := range items {

item := items[i]

var (

architecture string = "n/a"

os string = "n/a"

distro string = "n/a"

version string = "n/a"

)

if cfg := item.Config; cfg != nil {

if v := cfg.Architecture; v != nil {

architecture = *v

}

if v := cfg.OperatingSystem; v != nil {

os = *v

}

if v := cfg.OperatingSystemDistro; v != nil && v.IsSet() {

distro = *v.Get()

}

if v := cfg.OperatingSystemVersion; v != nil && v.IsSet() {

version = *v.Get()

}

}

table.AddRow(utils.PtrString(item.Id),

utils.PtrString(item.Name),

os,

architecture,

distro,

version,

utils.JoinStringKeysPtr(*item.Labels, ","))

}

err := table.Display(p)

if err != nil {

return fmt.Errorf("render table: %w", err)

}

return nil

})

see also the PR #1030 for reference

rubenhoenle · 2025-10-20T10:32:00Z

internal/cmd/beta/routingtable/route/update/update.go

+}
+
+func outputResult(p *print.Printer, outputFormat, routingTableId, networkAreaId string, route iaasalpha.Route) error {
+	switch outputFormat {


Please use the new Printer.OutputResult func here to save us the boilerplate code for the JSON/YAML output.

stackit-cli/internal/pkg/print/print.go

Lines 247 to 268 in 4725975

func (p *Printer) OutputResult(outputFormat string, output any, prettyOutputFunc func() error) error {

switch outputFormat {

case JSONOutputFormat:

details, err := json.MarshalIndent(output, "", " ")

if err != nil {

return fmt.Errorf("marshal json: %w", err)

}

p.Outputln(string(details))

return nil

case YAMLOutputFormat:

details, err := yaml.MarshalWithOptions(output, yaml.IndentSequence(true), yaml.UseJSONMarshaler())

if err != nil {

return fmt.Errorf("marshal yaml: %w", err)

}

p.Outputln(string(details))

return nil

default:

return prettyOutputFunc()

}

}

stackit-cli/internal/cmd/image/list/list.go

Lines 139 to 178 in 4725975

return p.OutputResult(outputFormat, items, func() error {

table := tables.NewTable()

table.SetHeader("ID", "NAME", "OS", "ARCHITECTURE", "DISTRIBUTION", "VERSION", "LABELS")

for i := range items {

item := items[i]

var (

architecture string = "n/a"

os string = "n/a"

distro string = "n/a"

version string = "n/a"

)

if cfg := item.Config; cfg != nil {

if v := cfg.Architecture; v != nil {

architecture = *v

}

if v := cfg.OperatingSystem; v != nil {

os = *v

}

if v := cfg.OperatingSystemDistro; v != nil && v.IsSet() {

distro = *v.Get()

}

if v := cfg.OperatingSystemVersion; v != nil && v.IsSet() {

version = *v.Get()

}

}

table.AddRow(utils.PtrString(item.Id),

utils.PtrString(item.Name),

os,

architecture,

distro,

version,

utils.JoinStringKeysPtr(*item.Labels, ","))

}

err := table.Display(p)

if err != nil {

return fmt.Errorf("render table: %w", err)

}

return nil

})

see also the PR #1030 for reference

h3adex requested a review from a team as a code owner October 10, 2025 14:23

feat(routing-table): provide rt and routes functionality

45f6702

h3adex force-pushed the feat/add-rt-support branch from 5b9fe56 to 45f6702 Compare October 10, 2025 14:24

h3adex commented Oct 10, 2025

View reviewed changes

rubenhoenle added the on-hold label Oct 16, 2025

rubenhoenle reviewed Oct 20, 2025

View reviewed changes

	func (p *Printer) OutputResult(outputFormat string, output any, prettyOutputFunc func() error) error {
	switch outputFormat {
	case JSONOutputFormat:
	details, err := json.MarshalIndent(output, "", " ")
	if err != nil {
	return fmt.Errorf("marshal json: %w", err)
	}
	p.Outputln(string(details))

	return nil
	case YAMLOutputFormat:
	details, err := yaml.MarshalWithOptions(output, yaml.IndentSequence(true), yaml.UseJSONMarshaler())
	if err != nil {
	return fmt.Errorf("marshal yaml: %w", err)
	}
	p.Outputln(string(details))

	return nil
	default:
	return prettyOutputFunc()
	}
	}

	return p.OutputResult(outputFormat, items, func() error {
	table := tables.NewTable()
	table.SetHeader("ID", "NAME", "OS", "ARCHITECTURE", "DISTRIBUTION", "VERSION", "LABELS")
	for i := range items {
	item := items[i]
	var (
	architecture string = "n/a"
	os string = "n/a"
	distro string = "n/a"
	version string = "n/a"
	)
	if cfg := item.Config; cfg != nil {
	if v := cfg.Architecture; v != nil {
	architecture = *v
	}
	if v := cfg.OperatingSystem; v != nil {
	os = *v
	}
	if v := cfg.OperatingSystemDistro; v != nil && v.IsSet() {
	distro = *v.Get()
	}
	if v := cfg.OperatingSystemVersion; v != nil && v.IsSet() {
	version = *v.Get()
	}
	}
	table.AddRow(utils.PtrString(item.Id),
	utils.PtrString(item.Name),
	os,
	architecture,
	distro,
	version,
	utils.JoinStringKeysPtr(*item.Labels, ","))
	}
	err := table.Display(p)
	if err != nil {
	return fmt.Errorf("render table: %w", err)
	}

	return nil
	})

	func GetSliceFromPointer[T any](s *[]T) []T {
	if s == nil \|\| *s == nil {
	return []T{}
	}
	return *s
	}

feat(routing-table): provide rt and routes functionality #1023

Are you sure you want to change the base?

feat(routing-table): provide rt and routes functionality #1023

Uh oh!

Conversation

h3adex commented Oct 10, 2025

Description

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

h3adex commented Oct 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants