-
Notifications
You must be signed in to change notification settings - Fork 25
refactor: implement a new output result func to handle json/yaml output in a central place #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4aad038 to
0c91dd5
Compare
marceljk
approved these changes
Oct 17, 2025
…ut in a central place
0c91dd5 to
442b6d1
Compare
Merging this branch changes the coverage (4 decrease, 223 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously basically every command had a
outputResultfunc which looked like the one below. Every singleoutputResultfunc duplicated the code for theJSON/YAMLoutput functionality.Now there's a new function implemented in the printer, which handles the
JSON/YAMLoutput for us in one central place so we don't have to duplicate the switch-statement for every subcommand.New function which can be found in
internal/pkg/print/print.go: It takes anoutputparam for theJSON/YAMLoutput and a callback function (prettyOutputFuncparam) so you can define a custom pretty output depending on your needs of the sub-command you're implementing.The new function can be used like this:
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)