Skip to content

feat(ske): Check service enablement only in error case#1457

Merged
Fyusel merged 1 commit into
mainfrom
check-enablement-only-in-error
Jul 7, 2026
Merged

feat(ske): Check service enablement only in error case#1457
Fyusel merged 1 commit into
mainfrom
check-enablement-only-in-error

Conversation

@Fyusel

@Fyusel Fyusel commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

STACKITCLI-287

Description

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel Fyusel requested a review from a team as a code owner July 6, 2026 09:04
Comment thread internal/cmd/ske/cluster/create/create.go Outdated
@Fyusel Fyusel force-pushed the check-enablement-only-in-error branch from 120b7d7 to 9fbfd47 Compare July 7, 2026 05:51
@Fyusel Fyusel force-pushed the check-enablement-only-in-error branch from 9fbfd47 to 60aab7b Compare July 7, 2026 12:04
STACKITCLI-287

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@Fyusel Fyusel force-pushed the check-enablement-only-in-error branch from 60aab7b to 24e4b9a Compare July 7, 2026 12:07
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/create 37.84% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/list 51.52% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/create/create.go 37.84% (ø) 74 28 46
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/list/list.go 51.52% (ø) 66 34 32

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@Fyusel Fyusel merged commit 1da14bc into main Jul 7, 2026
3 checks passed
@Fyusel Fyusel deleted the check-enablement-only-in-error branch July 7, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants