Skip to content

fix(ci): remove useless test step and lint-go job, adjust go build ma…#273

Merged
cgoetz-inovex merged 1 commit into
mainfrom
fix/STACKITSDK-399-remove-ci-linting-job
May 21, 2026
Merged

fix(ci): remove useless test step and lint-go job, adjust go build ma…#273
cgoetz-inovex merged 1 commit into
mainfrom
fix/STACKITSDK-399-remove-ci-linting-job

Conversation

@cgoetz-inovex
Copy link
Copy Markdown
Contributor

…trix

  • we only support the latest two go version
  • test step only tested generated tests, which do not exist
  • lint-go job removed waiters to prevent build failures on typecheck errors. This breaks typecheck in examples. Removing examples would need editing of go.work file before linting.
  • linting was called with skip-non-generated-files=true, but golangci-lint skips generated files by default. So this job linted nothing.

…trix

- we only support the latest two go version
- test step only tested generated tests, which do not exist
- lint-go job removed waiters to prevent build failures on typecheck
  errors. This breaks typecheck in examples. Removing examples would
  need editing of go.work file before linting.
- linting was called with `skip-non-generated-files=true`, but
  golangci-lint skips generated files by default. So this job linted
  nothing.
@cgoetz-inovex cgoetz-inovex requested a review from a team as a code owner May 21, 2026 15:14
@cgoetz-inovex cgoetz-inovex merged commit 4f30616 into main May 21, 2026
17 checks passed
@cgoetz-inovex cgoetz-inovex deleted the fix/STACKITSDK-399-remove-ci-linting-job branch May 21, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants