Skip to content

fix(core): prevent endless authentication loops #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marceljk merged 4 commits into from
Dec 17, 2025
Merged

fix(core): prevent endless authentication loops #160

marceljk merged 4 commits into from
Dec 17, 2025

Conversation

@marceljk
Copy link
Contributor

@marceljk marceljk commented Dec 12, 2025

Description

fix: prevent endless authentication loops
docs: document that OkHttp try requests always without Authenticator. When 401 returns, it retries the request with Authenticator

Checklist

  • Issue was linked above
  • No generated code was adjusted manually
  • Changelogs
    • Changelog in the root directory was adjusted
    • Changelog(s) of the service(s) were adjusted
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner December 12, 2025 12:46
@marceljk marceljk force-pushed the fix/prevent-loops-in-key-flow-authenticator branch 2 times, most recently from aa7bfbf to 1ca5a16 Compare December 15, 2025 10:51
rubenhoenle
rubenhoenle reviewed Dec 17, 2025
View reviewed changes
@marceljk
fix: prevent endless authentication loops
4695d29 
- docs: document that OkHttp try requests always without Authenticator and when 401 returns, it retries the request with Authenticator
@marceljk
bump VERSION file
e12a0a7
@marceljk
add unit tests for authenticate
f834336
rubenhoenle
rubenhoenle previously approved these changes Dec 17, 2025
View reviewed changes
@marceljk marceljk force-pushed the fix/prevent-loops-in-key-flow-authenticator branch from 1ca5a16 to d793323 Compare December 17, 2025 15:05
@marceljk marceljk merged commit 7ba2e6e into main Dec 17, 2025
4 checks passed
@marceljk marceljk deleted the fix/prevent-loops-in-key-flow-authenticator branch December 17, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenhoenle rubenhoenle rubenhoenle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marceljk @rubenhoenle