Skip to content

fix(ske): diff in plan triggers always replace because of network.id#1382

Merged
marceljk merged 1 commit intomainfrom
fix/STACKITTPR-614-ske-empty-network-results-in-replacement
Apr 22, 2026
Merged

fix(ske): diff in plan triggers always replace because of network.id#1382
marceljk merged 1 commit intomainfrom
fix/STACKITTPR-614-ske-empty-network-results-in-replacement

Conversation

@marceljk
Copy link
Copy Markdown
Contributor

Description

relates to STACKTTPR-614 and #1364

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner April 17, 2026 08:32
@marceljk marceljk force-pushed the fix/STACKITTPR-614-ske-empty-network-results-in-replacement branch 2 times, most recently from b272881 to 557e9d6 Compare April 21, 2026 16:20
@marceljk marceljk force-pushed the fix/STACKITTPR-614-ske-empty-network-results-in-replacement branch from 557e9d6 to 6876b86 Compare April 22, 2026 14:07
@marceljk marceljk enabled auto-merge (squash) April 22, 2026 14:08
@marceljk marceljk merged commit 35d5979 into main Apr 22, 2026
3 checks passed
@marceljk marceljk deleted the fix/STACKITTPR-614-ske-empty-network-results-in-replacement branch April 22, 2026 14:09
@github-actions
Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster 49.05% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/resource.go 51.29% (ø) 852 437 415

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/ske_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/ske_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants