Skip to content

fix(server): update network example to use "ipv4_nameservers" instead…#1410

Merged
rubenhoenle merged 2 commits intostackitcloud:mainfrom
DimitrijKimel:main
Apr 22, 2026
Merged

fix(server): update network example to use "ipv4_nameservers" instead…#1410
rubenhoenle merged 2 commits intostackitcloud:mainfrom
DimitrijKimel:main

Conversation

@DimitrijKimel
Copy link
Copy Markdown
Contributor

The stackit_servers network example uses argument "nameservers", but stackit_network requires "ipv4_nameservers" instead

Current:
image

image

Actual network documentation:
image

@DimitrijKimel DimitrijKimel requested a review from a team as a code owner April 22, 2026 08:39
@DimitrijKimel
Copy link
Copy Markdown
Contributor Author

I've made a pull request yesterday but messed up some stuff while setting up the tooling to generate the docs and it was easier for me to make a new pr.

I used make generate-docs this time like it was recommended

rubenhoenle
rubenhoenle previously approved these changes Apr 22, 2026
Copy link
Copy Markdown
Member

@rubenhoenle rubenhoenle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot 😊

@rubenhoenle
Copy link
Copy Markdown
Member

docs weren't generated properly, I fixed that for you @DimitrijKimel

@rubenhoenle rubenhoenle merged commit 8dfc54c into stackitcloud:main Apr 22, 2026
3 checks passed
@DimitrijKimel
Copy link
Copy Markdown
Contributor Author

Sorry for that, what exactly broke if I may ask? I am asking so I would know if I ever have to do it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants