Skip to content

Fix inconsistent result after apply in SKE cluster node pool taint value#606

Merged
joaopalet merged 2 commits intomainfrom
fix/cluster-node-pool-taint
Dec 3, 2024
Merged

Fix inconsistent result after apply in SKE cluster node pool taint value#606
joaopalet merged 2 commits intomainfrom
fix/cluster-node-pool-taint

Conversation

@joaopalet
Copy link
Copy Markdown
Contributor

@joaopalet joaopalet commented Nov 28, 2024

  • Fixes an inconsistent result after apply in SKE cluster node pool taint value
  • Error occured when a stackit_ske_cluster.nodepool[x].taints[x].value was left empty in the config, since the API returns "" in this case (instead of not providing the field in the response)
  • Making the field Computed is enough to fix the issue

@joaopalet joaopalet marked this pull request as ready for review November 29, 2024 13:59
Comment thread stackit/internal/services/ske/cluster/resource.go
@joaopalet
Copy link
Copy Markdown
Contributor Author

Relates to #602

@joaopalet joaopalet merged commit 51485f8 into main Dec 3, 2024
@joaopalet joaopalet deleted the fix/cluster-node-pool-taint branch December 3, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants