feat: add support for build args in spec.yaml files #220
+25
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements dockyard-side support for build args as described in #189. This allows spec.yaml files to specify additional CLI arguments that are baked into the container entrypoint.
Changes
argsfield toMCPServerPackageSpecstructgenerateDockerfile()to pass args toBuildFromProtocolSchemeWithNameImplementation Details
The
argsfield is optional and accepts an array of strings:These arguments are passed to the toolhive
BuildFromProtocolSchemeWithNamefunction, which appends them to the container entrypoint. For example, with the above spec, the generated Dockerfile will have:Benefits
thv run -- argsoverwrites default args instead of appendingBuildFromProtocolSchemeWithNamethat now supports thebuildArgsparameterTesting
Tested with local builds to verify args are correctly passed through to the generated Dockerfile.
Closes #189