Skip to content

Conversation

@JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 27, 2025

Summary

  • Documents the build environment configuration feature for custom package registries (Add CLI commands and template integration for build environment toolhive#2742)
  • Adds new "Custom package registries" section in the build-containers guide
  • Documents CLI commands: thv config set-build-env, get-build-env, unset-build-env
  • Includes table of common environment variables for npm, Go, and pip/uv
  • Adds troubleshooting section for custom registry issues

This allows enterprise environments to configure environment variables like NPM_CONFIG_REGISTRY, GOPROXY, and PIP_INDEX_URL that are injected into Dockerfiles during protocol scheme builds.

Test plan

  • npm run build passes
  • npm run prettier passes
  • Content follows existing documentation style and conventions

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings November 27, 2025 15:15
@vercel
Copy link

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-website Ready Ready Preview Comment Nov 27, 2025 5:57pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for the custom package registries feature in ToolHive, allowing enterprise users to configure environment variables for private package registries and mirrors. The documentation explains how to set, view, and remove build environment variables that are injected into Dockerfiles during protocol scheme builds.

  • Documents three new CLI commands: thv config set-build-env, get-build-env, and unset-build-env
  • Provides a reference table of common environment variables for npm, Go, and pip/uv package managers
  • Adds troubleshooting guidance for custom registry configuration issues

Comment on lines 384 to 401
#### View configured variables

To see all configured build environment variables:

```bash
thv config get-build-env
```

To view a specific variable:

```bash
thv config get-build-env NPM_CONFIG_REGISTRY
```

#### Remove build environment variables

To remove a specific variable:

```bash
thv config unset-build-env NPM_CONFIG_REGISTRY
```

To remove all configured build environment variables:

```bash
thv config unset-build-env --all
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This probably isn't needed in this section.

Document the build environment configuration feature for custom package
registries (toolhive#2742). This allows enterprise environments to configure
environment variables like NPM_CONFIG_REGISTRY, GOPROXY, and PIP_INDEX_URL
that are injected into Dockerfiles during protocol scheme builds.

Adds:
- New "Custom package registries" section in build-containers guide
- CLI commands: set-build-env, get-build-env, unset-build-env
- Table of common environment variables for npm, Go, and pip/uv
- Troubleshooting section for custom registry issues

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@JAORMX JAORMX merged commit 540a3ae into main Nov 27, 2025
4 of 6 checks passed
@JAORMX JAORMX deleted the docs/build-env-config branch November 27, 2025 18:20
jhrozek pushed a commit that referenced this pull request Dec 1, 2025
Document the build environment configuration feature for custom package
registries (toolhive#2742). This allows enterprise environments to configure
environment variables like NPM_CONFIG_REGISTRY, GOPROXY, and PIP_INDEX_URL
that are injected into Dockerfiles during protocol scheme builds.

Adds:
- New "Custom package registries" section in build-containers guide
- CLI commands: set-build-env, get-build-env, unset-build-env
- Table of common environment variables for npm, Go, and pip/uv
- Troubleshooting section for custom registry issues

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants