Drop 5-reviewer cap in upstream-release-docs#863
Merged
Conversation
Attempt assignment for every non-bot contributor in the release range instead of stopping after 5. The cap was systematically pushing contributors whose login sorts late alphabetically (e.g. tgrunnagle, yrobla) into the mention block without an assignment attempt on larger releases, which surfaced as inconsistent reviewer lists from one release to the next. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danbarr
approved these changes
May 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the upstream release-docs workflow to attempt reviewer assignment for all non-bot release contributors (instead of stopping after the first 5), reducing inconsistent behavior where late-sorting GitHub logins were skipped and only mentioned.
Changes:
- Removed the 5-candidate cap in the per-user reviewer assignment loop.
- Updated the contributor mention-block copy to remove the now-stale “review fatigue cap” wording.
Comment on lines
1041
to
1043
| if [ -n "$MENTION_LIST" ]; then | ||
| echo "Release contributors we couldn't auto-assign as reviewers (review fatigue cap or GitHub rejected the assignment). Mentioning them so they see the PR documenting their work:" | ||
| echo "Release contributors we couldn't auto-assign as reviewers (GitHub rejected the assignment). Mentioning them so they see the PR documenting their work:" | ||
| echo "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The reviewer-assignment step in
.github/workflows/upstream-release-docs.ymlstops attempting assignments after the first 5 candidates. Combined withjq's case-sensitive alphabetic sort on the candidate list, this means contributors whose login sorts late (e.g.tgrunnagle,yrobla) get dumped into the "Additional release contributors" mention block on big releases without an assignment attempt — even when GitHub would have accepted them. On smaller releases the same logins land inside the first 5 and get assigned normally, so the same person appears as a reviewer one week and as an @-mention the next.This PR drops the cap entirely and attempts every non-bot release contributor. The per-user attempt loop already isolates 422s, so removing the cap is safe — anyone GitHub rejects still falls through to the mention block. The mention-block copy is updated to drop the now-stale "review fatigue cap" wording.
The remaining cause of inconsistency — GitHub returning 422 for stackers whose only access is via the
stackersteam when called withGITHUB_TOKEN— is documented in the comment above the loop and will be addressed in a separate PR (likely by switching to a token withread:org).Type of change
Related issues/PRs
Follow-up: replace
GITHUB_TOKENfor the reviewer-assignment step with a token that hasread:org, to reduce 422s on team-only collaborators.🤖 Generated with Claude Code