fix: app version helm chart #114
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm chart version and appVersion from 0.1.0 to 0.0.2. The change appears to be reverting to an earlier version number rather than incrementing forward, which raises questions about version management consistency across the project.
- Chart version and appVersion downgraded from 0.1.0 to 0.0.2
Comment on lines
+5
to
+6
| version: 0.0.2 | ||
| appVersion: "0.0.2" |
There was a problem hiding this comment.
The Helm chart version is being changed from 0.1.0 to 0.0.2, which appears to be going backwards in semantic versioning. This creates an inconsistency with package.json which has version "0.1.0".
Consider:
- If this is meant to align with a previous release, ensure package.json is also updated to match
- If this is a new release, the version should typically increment forward (e.g., 0.1.1 or 0.2.0) rather than decrement
- Keeping versions synchronized between package.json and the Helm chart helps maintain consistency across deployment artifacts
Suggested change
| version: 0.0.2 | |
| appVersion: "0.0.2" | |
| version: 0.1.0 | |
| appVersion: "0.1.0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.