feat: add global error page #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppescg
approved these changes
Dec 2, 2025
Copilot finished reviewing on behalf of
kantord
December 2, 2025 14:18
There was a problem hiding this comment.
Pull request overview
This PR adds a global error boundary page for Next.js App Router to handle catastrophic errors that occur outside the root layout. It also includes a testing best practice guideline update.
- Adds
global-error.tsxwith a custom error UI featuring the ToolHive branding and a reset button - Updates testing documentation to recommend
toBeVisible()overtoBeInTheDocument()for better accessibility validation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app/global-error.tsx | Implements global error boundary with custom UI and reset functionality |
| AGENTS.md | Adds testing best practice guidance for visibility assertions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.