Conversation
There was a problem hiding this comment.
Pull request overview
Adds a visible current page indicator to the Catalog pagination UI, and improves perceived responsiveness during URL-driven filter/pagination updates (via React transitions).
Changes:
- Track and expose
pageNumberandisPendingfromuseCatalogFilters(usinguseTransition+ session cursor stack length). - Update
CatalogPaginationto show “Page N” and add a “First page” button with improved accessible labels. - Show a
ServerListSkeletonwhile transitions are pending; update unit tests for new labels/props.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/app/catalog/hooks/use-catalog-filters.ts |
Adds transition support + exposes isPending and pageNumber, plus a new handleFirstPage. |
src/app/catalog/components/servers-wrapper.tsx |
Renders skeleton while pending and wires new pagination props. |
src/app/catalog/components/server-list-skeleton.tsx |
Adjusts skeleton layout to match current grid spacing and increases placeholder count. |
src/app/catalog/components/catalog-pagination.tsx |
Adds first-page control and displays current page number; updates button accessible names. |
src/app/catalog/components/__tests__/servers-wrapper.test.tsx |
Updates assertions to match new pagination button accessible names. |
src/app/catalog/components/__tests__/catalog-pagination.test.tsx |
Adds coverage for first-page button + page number display; updates accessible-name expectations. |
9d4d7be to
5915ce3
Compare
samuv
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kapture.2026-03-05.at.15.03.03.mp4