Skip to content

feat: add current page number#383

Merged
peppescg merged 2 commits intomainfrom
feat-pagination-number
Mar 6, 2026
Merged

feat: add current page number#383
peppescg merged 2 commits intomainfrom
feat-pagination-number

Conversation

@peppescg
Copy link
Collaborator

@peppescg peppescg commented Mar 5, 2026

Kapture.2026-03-05.at.15.03.03.mp4

@peppescg peppescg self-assigned this Mar 5, 2026
Copilot AI review requested due to automatic review settings March 5, 2026 14:07
@github-actions github-actions bot added the size/S Small PR: 100-299 lines changed label Mar 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a visible current page indicator to the Catalog pagination UI, and improves perceived responsiveness during URL-driven filter/pagination updates (via React transitions).

Changes:

  • Track and expose pageNumber and isPending from useCatalogFilters (using useTransition + session cursor stack length).
  • Update CatalogPagination to show “Page N” and add a “First page” button with improved accessible labels.
  • Show a ServerListSkeleton while transitions are pending; update unit tests for new labels/props.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/app/catalog/hooks/use-catalog-filters.ts Adds transition support + exposes isPending and pageNumber, plus a new handleFirstPage.
src/app/catalog/components/servers-wrapper.tsx Renders skeleton while pending and wires new pagination props.
src/app/catalog/components/server-list-skeleton.tsx Adjusts skeleton layout to match current grid spacing and increases placeholder count.
src/app/catalog/components/catalog-pagination.tsx Adds first-page control and displays current page number; updates button accessible names.
src/app/catalog/components/__tests__/servers-wrapper.test.tsx Updates assertions to match new pagination button accessible names.
src/app/catalog/components/__tests__/catalog-pagination.test.tsx Adds coverage for first-page button + page number display; updates accessible-name expectations.

@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Mar 5, 2026
@peppescg peppescg force-pushed the feat-pagination-number branch from 9d4d7be to 5915ce3 Compare March 5, 2026 15:19
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Mar 5, 2026
@peppescg peppescg merged commit 4fbebf9 into main Mar 6, 2026
9 of 10 checks passed
@peppescg peppescg deleted the feat-pagination-number branch March 6, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants