refactor: handle missing publisher-provided in _meta server#427
Merged
refactor: handle missing publisher-provided in _meta server#427
Conversation
…rovided _meta from serve
There was a problem hiding this comment.
Pull request overview
This PR updates Stacklok metadata parsing so server detail rendering can gracefully handle servers that don’t include the io.modelcontextprotocol.registry/publisher-provided metadata block, avoiding downstream schema/metadata handling issues.
Changes:
- Update
parseStacklokMetato returnnullwhen Stacklok publisher metadata is absent. - Adjust utility helpers to handle
nullparse results safely. - Add Vitest coverage for missing vs valid Stacklok metadata parsing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/utils.ts | Treat parseStacklokMeta returning null as “no tools / not virtual” instead of dereferencing. |
| src/lib/schemas/server-meta.ts | Return null when Stacklok publisher-provided metadata is missing before running Zod validation. |
| src/lib/schemas/server-meta.test.ts | Add tests covering missing Stacklok metadata and successful parsing with valid metadata. |
peppescg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle missing meta info
server._meta?.["io.modelcontextprotocol.registry/publisher-provided"]?.[ "io.github.stacklok" ];in the server detailThis lead to zod mismatch error type, non a visibile error in the page.
Detail here https://discord.com/channels/1184987096302239844/1450739318376103998/1483027552393101403