Merged
Conversation
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
+ Coverage 57.54% 57.59% +0.05%
==========================================
Files 94 94
Lines 8460 8443 -17
==========================================
- Hits 4868 4863 -5
+ Misses 3261 3249 -12
Partials 331 331 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blkt
approved these changes
Mar 17, 2026
rdimitrov
added a commit
that referenced
this pull request
Mar 19, 2026
Reimplements main's #577 for the v1 branch. Previously each sync cycle fetched registry data twice: once in IsDataChanged (via CurrentHash) to check for changes, and again in PerformSync (via FetchRegistry). Now IsDataChanged calls FetchRegistry directly and threads the result through ShouldSync → PerformSync, eliminating the redundant fetch. - Remove CurrentHash from RegistryHandler interface and all implementations - IsDataChanged returns (bool, *FetchResult, error) - ShouldSync returns (Reason, *FetchResult) - PerformSync accepts optional prefetched *FetchResult Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
rdimitrov
added a commit
that referenced
this pull request
Mar 19, 2026
## Summary - Reimplements main's #577 for the v1 branch line - Removes redundant `CurrentHash` method from `RegistryHandler` interface — `IsDataChanged` now calls `FetchRegistry` directly and returns the fetched data - Threads prefetched `FetchResult` from `ShouldSync` → `PerformSync`, eliminating the second fetch per sync cycle - Adds `TestDefaultSyncManager_PerformSync_WithPrefetched` to verify prefetched data path ## Test plan - [x] Build passes - [x] Lint passes (0 issues) - [x] All sources and sync tests pass - [ ] CI passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CurrentHashfromRegistryHandlerinterface — it was a brokenabstraction that promised a lightweight hash check but performed a full
fetch in all three implementations (git, file, API)
IsDataChangednow callsFetchRegistrydirectly and returns theFetchResultalongside the changed/unchanged booleanShouldSyncthreads theFetchResultthrough toPerformSync, whichreuses it instead of fetching again — reducing fetches per sync cycle
from two to one for all source types
Test plan
task test)shouldSync:false, no storeFIxes #548