fix(build): drop appBundleId to restore macOS Squirrel auto-update#1959
Merged
fix(build): drop appBundleId to restore macOS Squirrel auto-update#1959
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Electron Forge build configuration to restore macOS Squirrel (zip-based) auto-update behavior by removing the explicit macOS bundle identifier override.
Changes:
- Removed
packagerConfig.appBundleIdfromforge.config.tsso macOS packaging uses the default bundle identifier behavior. - Deleted the now-unused
MACOS_BUNDLE_IDconstant fromcommon/app-info.ts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
forge.config.ts |
Drops the explicit appBundleId override in Forge packager config. |
common/app-info.ts |
Removes the unused MACOS_BUNDLE_ID export after the Forge config change. |
peppescg
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per title