test: use temporary user data dir for e2e tests#1960
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Playwright Electron E2E fixture to isolate Electron state per test run by launching the app with a temporary Chromium user data directory, reducing cross-test contamination.
Changes:
- Create a unique temporary
--user-data-dirfor each E2E run. - Remove the temporary user data directory after the Electron app closes.
kantord
force-pushed
the
use-temp-user-data-dir
branch
from
3a7cd34 to
61dee03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, end to end tests run in a temporary user data dir, instead of your global one. This improves test isolation for anything that depends on this path (namely, the sqlite db used for chat persistence for instance)