feat(skills): filter install skill client dropdown to supports_skills clients#1980
Merged
feat(skills): filter install skill client dropdown to supports_skills clients#1980
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Skills “Install skill” dialog to only offer clients that actually support ToolHive skill installation, aligning the UI with the new supports_skills field from the discovery clients API.
Changes:
- Filter the install-skill client dropdown to only include installed clients where
supports_skillsistrue. - Update the discovery clients mock fixture to include
supports_skillsfor all client entries. - Add a UI test asserting only skill-supporting clients appear in the dropdown.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
renderer/src/features/skills/components/dialog-install-skill.tsx |
Filters discovered installed clients to those with supports_skills: true before populating the Select. |
renderer/src/features/skills/components/__tests__/dialog-install-skill.test.tsx |
Adds a test that verifies non-skill-supporting installed clients are excluded from the dropdown. |
renderer/src/common/mocks/fixtures/discovery_clients/get.ts |
Extends the default mock discovery client list with supports_skills flags for each client. |
JAORMX
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install skill dialog showed all installed clients in the client dropdown, including clients that don't support ToolHive skill installation.
DialogInstallSkillto only include clients wheresupports_skills: true, using the new field added in Add supports_skills to GET /api/v1beta/discovery/clients response toolhive#4699supports_skillson all entries, withtruefor claude-code, opencode, and codex