refactor: use alias import for GeneralTab in settings-tabs#1992
Merged
refactor: use alias import for GeneralTab in settings-tabs#1992
Conversation
Change the GeneralTab import from relative (`./general-tab`) to alias-based (`@/common/components/settings/tabs/general-tab`) to allow enterprise overlays to swap the component via Vite alias without duplicating settings-tabs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the GeneralTab import in settings tabs to use an @/ alias path so enterprise overlays can swap the General tab implementation via Vite aliasing without copying settings-tabs.tsx.
Changes:
- Updated
GeneralTabimport insettings-tabs.tsxfrom a relative path to an alias-based path (@/...) to support overlay replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeneralTabimport insettings-tabs.tsxfrom relative (./general-tab) to alias-based (@/common/components/settings/tabs/general-tab)GeneralTabcomponent via Vite alias without having to duplicate the entiresettings-tabs.tsxfileTest plan
pnpm run type-checkandpnpm run lint🤖 Generated with Claude Code
Closes #2017