Skip to content

feat: support hiding experimental features via isEnterprise prop#2019

Merged
peppescg merged 1 commit intomainfrom
feat/hide-experimental-enterprise
Apr 16, 2026
Merged

feat: support hiding experimental features via isEnterprise prop#2019
peppescg merged 1 commit intomainfrom
feat/hide-experimental-enterprise

Conversation

@peppescg
Copy link
Copy Markdown
Collaborator

Summary

  • Add isEnterprise prop (default false) to GeneralTabWrapper
  • Conditionally hide <ExperimentalFeatures /> when isEnterprise is true
  • Add unit test for the enterprise case

Follows the same pattern used by TopNav and HelpDropdown for enterprise conditional rendering.

Related: stacklok/stacklok-enterprise-platform#413

Test plan

  • Existing tests pass (12/12)
  • New test verifies experimental section is hidden when isEnterprise={true}
  • Type-check passes
  • Lint passes

🤖 Generated with Claude Code

Add isEnterprise prop to GeneralTabWrapper (defaults to false) that
conditionally hides the ExperimentalFeatures section. This allows the
enterprise overlay to opt out of experimental features in settings.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 16, 2026 13:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an isEnterprise toggle to the General settings tab wrapper to allow enterprise builds to hide the Experimental Features section.

Changes:

  • Added optional isEnterprise prop (default false) to GeneralTabWrapper.
  • Conditionally renders <ExperimentalFeatures /> only when isEnterprise is false.
  • Added a unit test intended to verify the enterprise-hidden behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
renderer/src/common/components/settings/tabs/components/general-tab-wrapper.tsx Adds isEnterprise prop and uses it to gate rendering of Experimental Features.
renderer/src/common/components/settings/tabs/__tests__/general-tab.test.tsx Adds a test case for hiding Experimental Features when isEnterprise is true.

@peppescg peppescg self-assigned this Apr 16, 2026
@peppescg peppescg merged commit 4b8bcb0 into main Apr 16, 2026
24 checks passed
@peppescg peppescg deleted the feat/hide-experimental-enterprise branch April 16, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants