Skip to content

Do we need the tool config and the external auth controllers? #2662

@dmartinol

Description

@dmartinol

The tool config and the external auth controllers both trigger a new server reconciliation by updating one annotation in the referencing mcpservers.
Anyway, the server controller also watches the external auth resources to trigger the server reconciliation when the external auth get updated:

Watches(&mcpv1alpha1.MCPExternalAuthConfig{}, externalAuthConfigHandler).

Basically, this makes the external auth controller useless, IIUC.
Why not using the same watching mechanism for the tool config and get rid of both controllers at the end?

Metadata

Metadata

Assignees

No one assigned

    Labels

    kubernetesItems related to KubernetesoperatorquestionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions