-
Notifications
You must be signed in to change notification settings - Fork 156
make proxy runner to use current configmap #1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9fefd3b to
80db195
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1766 +/- ##
==========================================
+ Coverage 41.78% 41.91% +0.13%
==========================================
Files 184 185 +1
Lines 21533 21627 +94
==========================================
+ Hits 8997 9066 +69
- Misses 11841 11863 +22
- Partials 695 698 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9706236 to
89edb65
Compare
89edb65 to
903cf6c
Compare
dacc28d to
0d5a2c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the proxy runner to use a ConfigMap approach for configuration instead of command line arguments, implementing checksums for force redeployment of resources and updating tests to reflect the new changes.
Key changes:
- Replace individual CLI arguments with
--from-configmapflag in proxy runner - Add ConfigMap checksum support for tracking configuration changes and triggering redeployments
- Update operator to generate RunConfig ConfigMaps and use ConfigMap-based deployment
Reviewed Changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/proxy_runner_configmap_test.go | New E2E tests for ConfigMap-based proxy runner functionality |
| test/e2e/chainsaw/operator/single-tenancy/test-scenarios/sse/test-configmap-approach.yaml | Integration test validating ConfigMap approach in SSE transport scenarios |
| test/e2e/chainsaw/operator/*/test-scenarios/common/proxyrunner-role.yaml | Added ConfigMap read permissions for proxy runner RBAC |
| pkg/util/configmap.go | New utility function for computing ConfigMap checksums |
| pkg/util/configmap_test.go | Unit tests for ConfigMap checksum computation |
| pkg/runner/config.go | Added ConfigMapChecksum field to RunConfig structure |
| pkg/runner/config_builder.go | Default ProxyMode handling for stdio transport |
| pkg/runner/runner.go | Integration of ConfigMap checksum with Kubernetes deployer |
| pkg/container/kubernetes/client.go | Refactored deployment logic and added ConfigMap checksum annotation support |
| docs/server/swagger.yaml | Updated API documentation for new ConfigMapChecksum field |
| cmd/thv-proxyrunner/app/run.go | Added --from-configmap flag and ConfigMap loading functionality |
| cmd/thv-proxyrunner/app/run_test.go | Unit tests for new ConfigMap-based configuration |
| cmd/thv-operator/controllers/mcpserver_controller.go | Modified operator to use ConfigMap-based deployment approach |
| cmd/thv-operator/controllers/mcpserver_runconfig.go | Moved checksum computation to shared utility |
| cmd/thv-operator/controllers/mcpserver_runconfig_test.go | Updated tests to use shared checksum utility |
| cmd/thv-operator/controllers/mcpserver_pod_template_test.go | Updated tests for ConfigMap-based pod template configuration |
| cmd/thv-operator/controllers/mcpserver_resource_overrides_test.go | Removed duplicate/unused test function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2e64f31 to
aed0019
Compare
|
i will split in smaller prs as @ChrisJBurns requested. I know this grows and grows! |
modify the operator to use it instead of the command line arguments use checksums to force redeployment of resources update tests to reflect the new changes Closes: #1638
aed0019 to
658f140
Compare
modify the operator to use it instead of the command line arguments use checksums to force redeployment of resources
update tests to reflect the new changes
Closes: #1638