Skip to content

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Sep 10, 2025

It is covered as part of the runconfig but it was not supported as flag on the proxyrunner itself, while it was supported in run command

Related-to: #1638

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.07%. Comparing base (7e74099) to head (964649b).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1813      +/-   ##
==========================================
+ Coverage   42.03%   42.07%   +0.03%     
==========================================
  Files         184      184              
  Lines       21649    21662      +13     
==========================================
+ Hits         9101     9115      +14     
+ Misses      11860    11859       -1     
  Partials      688      688              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Collaborator

coveralls commented Sep 10, 2025

Coverage Status

coverage: 39.567% (-0.07%) from 39.637%
when pulling e098e8a on issue-1638-add-proxymode
into 5907c4a on main.

@yrobla yrobla force-pushed the issue-1638-add-proxymode branch from 495d807 to 6092c38 Compare September 10, 2025 09:25
@yrobla yrobla requested a review from Copilot September 10, 2025 09:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds missing support for proxy mode flag in the proxy runner command, enabling users to specify proxy mode directly via command line arguments. This feature was already supported in the run config but not exposed as a command-line flag in the proxy runner itself.

  • Adds --proxy-mode flag to the proxy runner command with default value "sse"
  • Updates operator to handle proxy mode from MCPServer spec with backward compatibility
  • Adds comprehensive tests to verify proxy mode flag functionality and validation

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cmd/thv-proxyrunner/app/run.go Adds proxy-mode flag definition, validation, and usage in runner configuration
cmd/thv-proxyrunner/app/run_test.go Adds comprehensive tests for proxy mode flag parsing, validation, and integration
cmd/thv-operator/api/v1alpha1/mcpserver_types.go Adds ProxyMode field to MCPServerSpec with validation constraints
cmd/thv-operator/controllers/mcpserver_runconfig.go Implements proxy mode handling in operator with default fallback
test/e2e/chainsaw/operator/single-tenancy/test-scenarios/configmap-mode/mcpserver.yaml Adds test configuration using streamable-http proxy mode
test/e2e/chainsaw/operator/single-tenancy/test-scenarios/configmap-mode/chainsaw-test.yaml Adds verification tests for proxy mode functionality in logs and ConfigMap
Comments suppressed due to low confidence (1)

cmd/thv-proxyrunner/app/run_test.go:1

  • The test case sets expectValid to false for invalid proxy mode, but the test doesn't actually validate the proxy mode value - it only tests flag parsing. The validation logic happens in runCmdFunc, not during flag parsing.
package app

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yrobla yrobla force-pushed the issue-1638-add-proxymode branch 3 times, most recently from e098e8a to e0c068e Compare September 10, 2025 09:45
It is covered as part of the runconfig but it was not supported
as flag on the proxyrunner itself, while it was supported in
run command

Related-to: #1638
@yrobla yrobla force-pushed the issue-1638-add-proxymode branch from e0c068e to 964649b Compare September 10, 2025 10:01
@yrobla yrobla merged commit 1aba180 into main Sep 10, 2025
29 checks passed
@yrobla yrobla deleted the issue-1638-add-proxymode branch September 10, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants