Include ToolsOverride in middleware population and allow empty tools filter #1889
+15
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change ensures PopulateMiddlewareConfigs passes both tools filter and tool overrides to the ToolFilter and ToolCallFilter middlewares. Middlewares are now applied when either a tools filter or overrides are provided (supports overrides-only).
Motivation
The proxyrunner path relies on PopulateMiddlewareConfigs (backward-compat bridge). Previously it only applied the tools filter and ignored tool overrides, causing proxyrunner to miss overrides that thv run supports. This brings parity so proxyrunner behaves like thv run for tool filtering/overrides.
Change details
Verification
go test ./pkg/... ./cmd/thv-proxyrunner/...— all passing.Impact