Add E2E tests for tool override functionality #1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
=======================================
Coverage 46.74% 46.75%
=======================================
Files 220 220
Lines 27378 27378
=======================================
+ Hits 12799 12801 +2
+ Misses 13601 13599 -2
Partials 978 978 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JAORMX
force-pushed
the
feat/add-e2e-tests-for-tool-override-1515
branch
from
5eebdca to
823261e
Compare
Implements missing E2E test coverage for the --tools-override CLI flag as requested in GitHub issue #1515. Test coverage includes: - Positive cases: valid overrides with name/description changes - Negative cases: invalid JSON, missing files, empty overrides - Integration cases: combining tool filtering with tool overrides The tests follow the existing pattern in fetch_mcp_server_test.go and will run under the 'mcp' label in CI pipeline. Closes #1515 Signed-off-by: toolhive-dev-bot <devnull@example.com>
JAORMX
force-pushed
the
feat/add-e2e-tests-for-tool-override-1515
branch
from
823261e to
a0084b1
Compare
JAORMX
changed the title
yrobla
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements missing E2E test coverage for the
--tools-overrideCLI flag as requested in GitHub issue #1515.Testing
The tests will automatically run in CI under the "mcp" label filter, ensuring they're included in the existing test pipeline.
Closes #1515