Remove unimplemented StepTypeConditional #2612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the StepTypeConditional constant and all related code that was added as a placeholder but never designed or implemented. This constant caused confusion as it suggested a feature that doesn't exist. The `condition` field on workflow steps (which enables conditional execution via template evaluation) remains unchanged and fully functional. This change only removes the unused step type constant. Changes: - Remove StepTypeConditional constant from composer package - Remove conditional case from workflow execution switch - Remove conditional validation case - Remove conditional parsing from workflow converter - Update step type documentation comment All tests pass. The Kubernetes CRD already has the correct enum (tool;elicitation) without the conditional type.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
=======================================
Coverage 55.85% 55.85%
=======================================
Files 312 312
Lines 29541 29531 -10
=======================================
- Hits 16501 16496 -5
+ Misses 11599 11593 -6
- Partials 1441 1442 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrobla
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
StepTypeConditionalconstant and all related code that was added as a placeholder but never designed or implemented in the proposal.Background
The constant was added in #2439 alongside the
conditionfield implementation, but:What Changed
StepTypeConditionalconstant from composer packageWhat Stays the Same
The
conditionfield on workflow steps remains unchanged and fully functional. This field enables conditional execution via template evaluation (e.g.,condition: "{{.steps.confirm.output.action == 'accept'}}").Testing
tool;elicitation)Notes
One test (
TestDAGExecutor_ComplexWorkflow) shows intermittent flakiness with the race detector (timing-sensitive parallel execution test), but passes consistently without it. This is unrelated to these changes.